Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isHome property to routes and update breadcrumb logic #65

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

alecarn
Copy link
Contributor

@alecarn alecarn commented Jan 27, 2025

Pour corriger des bogues de détection, je propose de déclarer de manière statique qui est la route parente. Ça va nous permettre plus de contrôles et de stabilités

@alecarn alecarn requested a review from LAMM26 January 27, 2025 16:11
@alecarn alecarn self-assigned this Jan 27, 2025
Copy link
Collaborator

@LAMM26 LAMM26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semble être ok. La seule chose étrange est quand on est sur la page d'accueil/À propos, les breadcrumbs agissent comme si on était un niveau plus loin que la page d'accueil. Semble faire la même chose dans le site du SDG.

@alecarn
Copy link
Contributor Author

alecarn commented Jan 27, 2025

C'était pour répliquer la structure de https://design.quebec.ca/:
image

On a tout de même le controle de configuration pour conserver la page d'accueil sans Breadcrumbs:
image

@LAMM26
Copy link
Collaborator

LAMM26 commented Jan 27, 2025

Oui c'est correct! C'est juste un drôle de comportement que je n'avais jamais remarqué sur le site du Guide.

@alecarn alecarn force-pushed the fix/breadcrumbs-home-route-detection branch 2 times, most recently from 6ffab46 to 0286940 Compare January 27, 2025 17:57
@alecarn alecarn force-pushed the fix/breadcrumbs-home-route-detection branch from 0286940 to 572bca7 Compare January 27, 2025 17:59
@alecarn alecarn merged commit 849895e into next Jan 27, 2025
2 checks passed
@alecarn alecarn deleted the fix/breadcrumbs-home-route-detection branch January 27, 2025 18:00
@alecarn
Copy link
Contributor Author

alecarn commented Jan 27, 2025

🎉 This PR is included in version 1.0.0-next.45 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants