-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sequential-links): add sequential links component #18
Conversation
@@ -0,0 +1,20 @@ | |||
<div class="container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Est-ce qu'on pourrait utiliser le host comme container, au lieu d'ajouter un div?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pas certain de comprendre ce que tu veux dire? Ça serait <sdg-sequential-links>
qui contiendrait direct les deux et faire le scss de cet élément dans la démo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On ajoute parfois un div intermédiaire entre le host et le contenu de la composante pour ajouté du style ou des classes. Par exemple, ton <div class="container">
ce situe entre le deux, il est utilisé seulement pour ajouté une classe mais ce style ou cette classe pourrait se retrouver sur le host de la composante.
On peut styler le host de la composante via le fichier SCSS et la balise :host {}
ou
Ajouter un HostBinding @HostBinding('class.container') containerClass = true;
qui permet d'ajouter la classe container <sdg-sequential-links class="container">
packages/sdg/src/lib/sequential-links/sequential-links.component.html
Outdated
Show resolved
Hide resolved
packages/sdg/src/lib/sequential-links/sequential-links.component.ts
Outdated
Show resolved
Hide resolved
🎉 This PR is included in version 1.0.0-next.21 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Nouveau composant de liens séquentiels. Ajout à la démo