Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sequential-links): add sequential links component #18

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

LAMM26
Copy link
Collaborator

@LAMM26 LAMM26 commented Sep 3, 2024

Nouveau composant de liens séquentiels. Ajout à la démo

@LAMM26 LAMM26 added the enhancement New feature or request label Sep 3, 2024
@LAMM26 LAMM26 self-assigned this Sep 3, 2024
@@ -0,0 +1,20 @@
<div class="container">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce qu'on pourrait utiliser le host comme container, au lieu d'ajouter un div?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas certain de comprendre ce que tu veux dire? Ça serait <sdg-sequential-links> qui contiendrait direct les deux et faire le scss de cet élément dans la démo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On ajoute parfois un div intermédiaire entre le host et le contenu de la composante pour ajouté du style ou des classes. Par exemple, ton <div class="container"> ce situe entre le deux, il est utilisé seulement pour ajouté une classe mais ce style ou cette classe pourrait se retrouver sur le host de la composante.

On peut styler le host de la composante via le fichier SCSS et la balise :host {}
ou
Ajouter un HostBinding @HostBinding('class.container') containerClass = true; qui permet d'ajouter la classe container <sdg-sequential-links class="container">

@LAMM26 LAMM26 merged commit 0aaaa01 into next Sep 18, 2024
3 checks passed
@LAMM26 LAMM26 deleted the sequential-links branch September 18, 2024 19:50
@alecarn
Copy link
Contributor

alecarn commented Sep 18, 2024

🎉 This PR is included in version 1.0.0-next.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants