Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(paginator): add paginator component #12
feat(paginator): add paginator component #12
Changes from 9 commits
08d042c
dd9d3c8
638fb3a
6e357c5
60a4daa
0b3a966
73e36e1
5ca503a
c2aa501
9f6ee0e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Est-ce qu'on pourrait convertir en bouton icone pour améliorer l'accessibilité?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ça pourrait être intéressant, mais du CSS du mat-button à ajuster pour les différents états qui je pense n'est pas idéal. J'ai modifié le html pour ajouté un
keyup
event et du focus.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, j'ai l'impression qu'avec le
<button mat-icon-button ...
tu serais arrivé au même résultat mais en utilisant les composantes de bouton.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En fait c'est visible en faisant un hover sur les chevrons Previous et Next qui ont une ombre ciculaire au lieu de rectangulaire comme dans le SDG. Peut-être en utilisant un button régulier. Je peux tester.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il y a deux manière d'injecter dans Angular et tu utilises les deux dans la même composante, soit injecter dans le constructeur (ex:
private document: Document
) ou directement comme tu le fais. Il n'y a pas de bonne ou mauvaise mais idéallement on utilise un ou l'autre.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Même ces paramètres auraient pu être convertie en computed (Signal). Il y a surement un niveau de complexité vu qu'il y a beaucoup de manipulation et dépendances. Cela pourrait être un nice to have éventuellement...