Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Commit

Permalink
chore: make aggregated proof types the same as Sovereign SDK (#128)
Browse files Browse the repository at this point in the history
* chore: make zk proof protos the same as Sovereign types

* chore: update basecoin rev

* fix: add missing From conversions

* chore: update basecoin rev

* docs: add a note why using identical aggregated proof type definitions
  • Loading branch information
Farhad-Shabani authored Apr 8, 2024
1 parent 1b005f6 commit 97d81ce
Show file tree
Hide file tree
Showing 18 changed files with 392 additions and 310 deletions.
44 changes: 23 additions & 21 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion clients/sov-celestia/src/client_state/misbehaviour.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ where
)?;

// TODO: Determine what sort of checks we need to carry out for detecting
// `AggregatedProofData` misbehaviour.
// `AggregatedProof` misbehaviour.

Ok(())
}
4 changes: 2 additions & 2 deletions clients/sov-celestia/src/client_state/update_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ where
verifier,
)?;

// TODO: Implement the verification of the `AggregatedProofData`.
// aggregated_proof_date.verify()?;
// TODO: Implement the verification of the `AggregatedProof`.
// aggregated_proof.verify()?;

Ok(())
}
Expand Down
3 changes: 3 additions & 0 deletions clients/sov-celestia/types/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ tendermint = { workspace = true }
tendermint-proto = { workspace = true }
tendermint-light-client-verifier = { workspace = true }

# sovereign dependencies
sov-rollup-interface = { workspace = true }

[features]
default = ["std"]
std = [
Expand Down
Loading

0 comments on commit 97d81ce

Please sign in to comment.