Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ibc-apps errors #1318

Merged
merged 6 commits into from
Aug 22, 2024

Simplify NftTransferError variant

c0a3e2a
Select commit
Loading
Failed to load commit list.
Merged

Clean up ibc-apps errors #1318

Simplify NftTransferError variant
c0a3e2a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 20, 2024 in 1s

66.99% (+66.99%) compared to 60ff9bd

View this Pull Request on Codecov

66.99% (+66.99%) compared to 60ff9bd

Details

Codecov Report

Attention: Patch coverage is 15.78947% with 96 lines in your changes missing coverage. Please review.

Project coverage is 66.99%. Comparing base (60ff9bd) to head (c0a3e2a).

Files Patch % Lines
ibc-apps/ics721-nft-transfer/src/module.rs 17.39% 19 Missing ⚠️
ibc-apps/ics721-nft-transfer/types/src/packet.rs 0.00% 19 Missing ⚠️
ibc-apps/ics20-transfer/src/module.rs 14.28% 18 Missing ⚠️
ibc-apps/ics20-transfer/types/src/msgs/transfer.rs 0.00% 7 Missing ⚠️
ibc-apps/ics721-nft-transfer/types/src/token.rs 30.00% 7 Missing ⚠️
.../ics721-nft-transfer/src/handler/on_recv_packet.rs 0.00% 6 Missing ⚠️
...pps/ics721-nft-transfer/types/src/msgs/transfer.rs 0.00% 5 Missing ⚠️
...s/ics721-nft-transfer/src/handler/send_transfer.rs 0.00% 4 Missing ⚠️
ibc-apps/ics20-transfer/src/handler/mod.rs 0.00% 2 Missing ⚠️
ibc-apps/ics721-nft-transfer/src/handler/mod.rs 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           error-handling    #1318       +/-   ##
===================================================
+ Coverage                0   66.99%   +66.99%     
===================================================
  Files                   0      227      +227     
  Lines                   0    23451    +23451     
===================================================
+ Hits                    0    15712    +15712     
- Misses                  0     7739     +7739

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov