add InvalidUpgradePath

informalsystems · Aug 8, 2024 · cc4bff4 · cc4bff4
1 parent 45fe2e5
commit cc4bff4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/ibc-clients/ics07-tendermint/src/client_state/common.rs b/ibc-clients/ics07-tendermint/src/client_state/common.rs
@@ -56,20 +56,21 @@ impl ClientStateCommon for ClientState {
         let upgrade_path = &self.inner().upgrade_path;
         let (upgrade_path_prefix, upgrade_path) = match upgrade_path.len() {
             0 => {
-                return Err(ClientError::ClientSpecific {
-                    description: "cannot upgrade client as no upgrade path has been set"
-                        .to_string(),
-                });
+                return Err(UpgradeClientError::InvalidUpgradePath {
+                    reason: "no upgrade path has been set".to_string(),
+                }
+                .into());
             }
             1 => (CommitmentPrefix::empty(), upgrade_path[0].clone()),
             2 => (
                 upgrade_path[0].as_bytes().to_vec().into(),
                 upgrade_path[1].clone(),
             ),
             _ => {
-                return Err(ClientError::ClientSpecific {
-                    description: "upgrade client failed: upgrade path is too long".to_string(),
-                })
+                return Err(UpgradeClientError::InvalidUpgradePath {
+                    reason: "upgrade path is too long".to_string(),
+                }
+                .into());
             }
         };
 

diff --git a/ibc-core/ics02-client/types/src/error.rs b/ibc-core/ics02-client/types/src/error.rs
@@ -151,6 +151,8 @@ pub enum UpgradeClientError {
         upgraded_height: Height,
         client_height: Height,
     },
+    /// Invalid upgrade path: `{reason}`
+    InvalidUpgradePath { reason: String },
     /// invalid upgrade proposal: `{reason}`
     InvalidUpgradeProposal { reason: String },
     /// invalid upgrade plan: `{reason}`