Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return-txn-current-if-exists #432

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

brucecurcio
Copy link

No description provided.

@brucecurcio brucecurcio force-pushed the return-txn-current-if-exists branch from e6c3c24 to ad36bbd Compare January 14, 2025 22:52
@brucecurcio brucecurcio force-pushed the return-txn-current-if-exists branch from ad36bbd to 9dd9ac4 Compare January 14, 2025 22:57
@brucecurcio brucecurcio marked this pull request as ready for review January 14, 2025 22:58
@akleinib
Copy link

Are these changes still prevent scenarios like:

  1. Caller requested a R-O transaction first then requests a R/W transaction,
  2. Caller requested a R-O transaction with isolation level A first then requests a R-O transaction with isolation level B,
  3. ...

?

For those cases we shouldn't return the current transaction if the newly requested transaction doesn't match the characteristics of the existing one.

@brucecurcio
Copy link
Author

brucecurcio commented Jan 15, 2025

Are these changes still prevent scenarios like:

  1. Caller requested a R-O transaction first then requests a R/W transaction,
  2. Caller requested a R-O transaction with isolation level A first then requests a R-O transaction with isolation level B,
  3. ...

?

For those cases we shouldn't return the current transaction if the newly requested transaction doesn't match the characteristics of the existing one.

as discussed, i put in a check that prevents attempts to change from RO DB to RW DB but returns the existing db txn in all other cases.

@brucecurcio brucecurcio requested a review from akleinib January 15, 2025 22:21
@brucecurcio brucecurcio force-pushed the return-txn-current-if-exists branch from a64ac44 to 98e7b4b Compare January 15, 2025 22:35
@brucecurcio brucecurcio force-pushed the return-txn-current-if-exists branch from 98e7b4b to 9af4f20 Compare January 15, 2025 22:40
@brucecurcio brucecurcio merged commit 3207f3d into v0.25 Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants