fix: Correct several issues found during #4740 #4786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 24, 2022 19:07
skartikey
reviewed
May 25, 2022
| @@ -43,10 +43,16 @@ pub type SemanticPackageMap = SemanticMap<String, Package>; | |||
| /// Infers the Flux standard library given the path to the source code. | |||
| /// The prelude and the imports are returned. | |||
| #[allow(clippy::type_complexity)] | |||
| pub fn infer_stdlib_dir(path: &Path) -> Result<(PackageExports, Packages, SemanticPackageMap)> { | |||
| pub fn infer_stdlib_dir( | |||
There was a problem hiding this comment.
the second argument needs to be supplied here as well. else it will return an error.
flux/libflux/flux/benches/basic.rs
Line 30 in 5a828bd
skartikey
reviewed
May 25, 2022
| @@ -43,10 +43,16 @@ pub type SemanticPackageMap = SemanticMap<String, Package>; | |||
| /// Infers the Flux standard library given the path to the source code. | |||
| /// The prelude and the imports are returned. | |||
| #[allow(clippy::type_complexity)] | |||
| pub fn infer_stdlib_dir(path: &Path) -> Result<(PackageExports, Packages, SemanticPackageMap)> { | |||
| pub fn infer_stdlib_dir( | |||
There was a problem hiding this comment.
the second argument needs to be supplied here as well. else it will return an error.
flux/libflux/flux/benches/basic.rs
Line 30 in 5a828bd
skartikey
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes and refactorings I have done so for for #4740 . Reviewing commit by commit is recommended.