perf: Avoid allocating a String for each formatted operator #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the parse/display of operators to use a common macro which removes duplication and ensures that we cover all variants. I changed `ToString for LogicalOperator` to a `fmt::Display` implementation as there is a default implementation that auto implements `ToString` (`ToString for T where T: fmt::Display`).
onelson
approved these changes
May 9, 2022
|
Yeah, this won't do anything to fix the issue itself, it just removes some unnecessary work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the parse/display of operators to use a common macro which removes duplication
and ensures that we cover all variants. I changed
ToString for LogicalOperatorto afmt::Displayimplementation as there is a default implementation that auto implements
ToString(ToString for T where T: fmt::Display).cc #4712