Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose label polymorphism via an opt-in feature #4928

Closed
Marwes opened this issue Jun 27, 2022 · 1 comment
Closed

Expose label polymorphism via an opt-in feature #4928

Marwes opened this issue Jun 27, 2022 · 1 comment

Comments

@Marwes
Copy link
Contributor

Marwes commented Jun 27, 2022

To let type signatures take advantage of label polymorphism without breaking backwards compatibility we will add an opt-in compilation option that tells the compiler to use the label polymorphic function signatures.

How should the option be enabled

  • Via an explicit option at the command line or GUI?
  • Should we enable this option if the label syntax (.mylabel) is used in the script? ( Add a syntax to describe label values #4927 )
  • Something like javscripts "use strict" in the script itself?
  • If the script uses the label syntax, auto enable the feature
  • Explicit Flux major versions

Since the feature changes the pre-compiled standard library we must either compile it twice, or ensure that we retain both signatures in one pre-compilation and information on how to select which (the former is easier, but less efficient).

(Based on the comment #4776 (comment) )

DOD

  • When compiling we can select either the old or the new function signatures to use when typehecking
Marwes pushed a commit that referenced this issue Aug 25, 2022
Adds the syntax and locks it behind the `LabelPolymorphism` feature flag.
(#4928 exists as the next step to allow users to actually opt-in to it).

Closes #4927
Marwes pushed a commit that referenced this issue Sep 7, 2022
Adds the syntax and locks it behind the `LabelPolymorphism` feature flag.
(#4928 exists as the next step to allow users to actually opt-in to it).

Closes #4927
Marwes pushed a commit that referenced this issue Sep 7, 2022
Adds the syntax and locks it behind the `LabelPolymorphism` feature flag.
(#4928 exists as the next step to allow users to actually opt-in to it).

Closes #4927
Marwes pushed a commit that referenced this issue Sep 8, 2022
* feat: Add a syntax for describing label literals

Adds the syntax and locks it behind the `LabelPolymorphism` feature flag.
(#4928 exists as the next step to allow users to actually opt-in to it).

Closes #4927

* test: Allow label literals in testcases

* chore: make generate
@github-actions
Copy link

This issue has had no recent activity and will be closed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant