fix(cli): remove sharp dependency #2524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(cli): update generator for expo only * refactor(boilerplate): App to typescript * chore: simplify w/ expo * chore: reanimated deps, other dep clean up * fix(boilerplate): removed problematic @expo/metro-config to run dev client * chore: updated native dirs as per expo dev client build * chore: updates to latest Expo SDK * test: update app-icon / splash section * fix(cli): rename bridging header and entitlements * chore(boilerplate): dep update * docs(folder-structure): updated for rework * chore: updates due to structure changes, tests passing 🤞 * fix(generators): add new line to end of app.json * chore: update reactotron dev deps * fix(boilerplate): WelcomeScreen needs this import even if demo removed * fix(cli): remove deprecrated expo flag * fix(boilerplate): match babel config more closely to expo default * chore(cli): reactotron deps * feat(cli): prompt for enabling new arch * chore: remove unused log statements * chore: expect TS error for now * chore(boilerplate): RN 0.72.3 --------- Co-authored-by: Joshua Yoes <joshua.r.yoes@gmail.com>
moved assets/icons that only pertain to demo into subdir for removal via remove-demo
* feat(boilerplate): added `withSplashScreen` config plugin * docs: updated for local config plugin file structure
drop NA question for Expo Go
Co-authored-by: Mazen Chami <mazenchami@gmail.com>
* chore(release): 8.8.7 [skip ci] ## [8.8.7](v8.8.6...v8.8.7) (2023-08-08) ### Bug Fixes * **cli:** correct cd command when targetPath has changed ([#2488](#2488) by bradherman) ([19a161e](19a161e)) * feat(cli): add bun support * fix: Specifies version of @expo/webpack-config to avoid dependency failure. (#2502 by @jamonholmgren) * chore(release): 8.8.8 [skip ci] ## [8.8.8](v8.8.7...v8.8.8) (2023-09-19) ### Bug Fixes * Specifies version of @expo/webpack-config to avoid dependency failure. ([#2502](#2502) by [@jamonholmgren](https://github.com/jamonholmgren)) ([94ddb85](94ddb85)) * docs: Update README.md -- add Getting Started video link (#2501 by @jamonholmgren) [skip ci] * Switch to bun for boilerplate scripts * Use bun for CI tests * Bump for ci * remove demo app * Bump bun-orb version * bump bun-orb * fix: removed ios remnants merge from main probably * fix(cli): display bun run command --------- Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Jamon Holmgren <jamonholmgren@gmail.com> Co-authored-by: Jamon Holmgren <code@jamon.dev>
* fix(cli): Expo Go compat deps * feat(tests) Add expo go config changes tests I also moved around the expo go configuration and `findAndUpdateDependencyVersions()` function so that it would be easier to test. --------- Co-authored-by: Mark Rickert <mjar81@gmail.com>
…2513) * feat(boilerplate) @shopify/flash-list integration This integrates @shopify/flash-list in all places where we used to have a FlatList and updates the expo to compatibility object to use the correct expected version while using the latest for expo prebuild and bare workflows. * fix: ios compiling issue when the user specifies the new architecture * fix: Get FlashList working in new architecture using interop layer iOS seems to have problems with flashlist using interop, but android seems to work just fine. * feat: adds ListView Higher Order Component Displays a FlashList or FlatList depending on language RTL features. Needs a little more work on the `ref` passing. * chore: formatting * refactor(boilerplate): ListView HOC types * chore(tests) Tests passing after adding new ListView component * ci: bun version lock --------- Co-authored-by: Frank Calise <fcalise@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
sharpas a dependency to the CLI which has been linked to many issues: 8.8.3 Causes sharp module issue #2483, v9: Prebuild doesn't complete with yarn2 #2518buffer-image-sizeassharp-clidoesn't allow for printing metadata yet (see old PR)sharp-cliStill Pending
sharp-cliat all since maybe that will blockbunadoption still? (although unsure)