Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unittest stuck #1192

Merged
merged 9 commits into from
May 9, 2024
Merged

Fix unittest stuck #1192

merged 9 commits into from
May 9, 2024

Conversation

small-turtle-1
Copy link
Contributor

@small-turtle-1 small-turtle-1 commented May 8, 2024 •
edited
Loading

What problem does this PR solve?

  1. Fix: cleanup processor get visit_ts from txn_manager, visit_ts is Min(first_uncommitted_begin_ts, last_checkpoint_ts)
  2. Fix: config file typo.

Issue link:#1172

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

@small-turtle-1 small-turtle-1 added ci PR can be test wip work in progress and removed wip work in progress ci PR can be test labels May 8, 2024
@small-turtle-1 small-turtle-1 added ci PR can be test and removed ci PR can be test labels May 8, 2024
@small-turtle-1 small-turtle-1 added ci PR can be test and removed ci PR can be test labels May 8, 2024
@small-turtle-1 small-turtle-1 added ci PR can be test and removed ci PR can be test labels May 8, 2024
@small-turtle-1 small-turtle-1 force-pushed the fix_unittest_stuck branch 2 times, most recently from 9207186 to b826097 Compare May 9, 2024 03:38
@small-turtle-1 small-turtle-1 added ci PR can be test and removed ci PR can be test labels May 9, 2024
@small-turtle-1 small-turtle-1 removed the wip work in progress label May 9, 2024
@small-turtle-1 small-turtle-1 changed the title Fix unittest stuck (use ci to debug) Fix unittest stuck May 9, 2024
@small-turtle-1 small-turtle-1 added ci PR can be test and removed ci PR can be test labels May 9, 2024
@JinHai-CN JinHai-CN merged commit af24a07 into infiniflow:main May 9, 2024
3 checks passed
@small-turtle-1 small-turtle-1 deleted the fix_unittest_stuck branch May 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci PR can be test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@small-turtle-1 @JinHai-CN