Skip to content

Commit

Permalink
Fix HNSW build thread pool size is 0
Browse files Browse the repository at this point in the history
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
  • Loading branch information
JinHai-CN committed Mar 10, 2025
1 parent e8aa943 commit 68e7d36
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
12 changes: 6 additions & 6 deletions src/main/infinity_context.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -506,16 +506,16 @@ void InfinityContext::UnInit() {

void InfinityContext::SetIndexThreadPool() {
LOG_TRACE("Set index thread pool.");
inverting_thread_pool_.resize(config_->DenseIndexBuildingWorker());
commiting_thread_pool_.resize(config_->SparseIndexBuildingWorker());
hnsw_build_thread_pool_.resize(config_->FulltextIndexBuildingWorker());
inverting_thread_pool_.resize(config_->FulltextIndexBuildingWorker());
commiting_thread_pool_.resize(config_->FulltextIndexBuildingWorker());
hnsw_build_thread_pool_.resize(config_->DenseIndexBuildingWorker());
}

void InfinityContext::RestoreIndexThreadPoolToDefault() {
LOG_TRACE("Restore index thread pool size to default.");
inverting_thread_pool_.resize(config_->DenseIndexBuildingWorker());
commiting_thread_pool_.resize(config_->SparseIndexBuildingWorker());
hnsw_build_thread_pool_.resize(config_->FulltextIndexBuildingWorker());
inverting_thread_pool_.resize(config_->FulltextIndexBuildingWorker());
commiting_thread_pool_.resize(config_->FulltextIndexBuildingWorker());
hnsw_build_thread_pool_.resize(config_->DenseIndexBuildingWorker());
}

void InfinityContext::AddThriftServerFn(std::function<void()> start_func, std::function<void()> stop_func) {
Expand Down
4 changes: 3 additions & 1 deletion src/storage/knn_index/knn_hnsw/abstract_hnsw.cppm
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import base_memindex;
import memindex_tracer;
import table_index_entry;
import buffer_handle;
import third_party;

namespace infinity {

Expand Down Expand Up @@ -112,7 +113,8 @@ private:
static void InsertVecs(Index &index, Iter &&iter, const HnswInsertConfig &config, SizeT &mem_usage) {
auto &thread_pool = InfinityContext::instance().GetHnswBuildThreadPool();
if (thread_pool.size() == 0) {
UnrecoverableError("Hnsw build thread pool is not initialized.");
LOG_CRITICAL(fmt::format("Dense index building worker: {}", InfinityContext::instance().config()->DenseIndexBuildingWorker()));
UnrecoverableError("Hnsw build thread pool size is 0, config.");
}
using T = std::decay_t<decltype(index)>;
if constexpr (!std::is_same_v<T, std::nullptr_t>) {
Expand Down

0 comments on commit 68e7d36

Please sign in to comment.