fix(ui): Label Position Resets After Changing Number of Rows

[HecticKiwi]

Description

When you change the label position to right or top, then change the number of rows, the label position reverted to Left.

This was because changing the number of rows updates the search params, which in turn triggers the useEffect() that reloads the tier list with the new search param data. This data doesn't include the label position, so it was defaulting to left.

Fixed by assigning the labelPosition on the search param data tiers before the call to setTiers().

Screenshots

Before

Screen.Recording.2024-12-27.220010.mp4

After

Screen.Recording.2024-12-27.214537.mp4

Checklist:

• My changes generate no new warnings or errors
• I have verified that these changes don't negatively impact performance
• Also optimized for mobile layouts

Summary by CodeRabbit

Summary by CodeRabbit

• Bug Fixes
  • Enhanced error handling for tier state decoding from the URL.
  • Ensured consistent label positioning across tier list updates.
  • Improved dynamic updates to the tier list based on user interactions.

[vercel]

@HecticKiwi is attempting to deploy a commit to the Infinia Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The changes in the TierListManager.tsx component enhance the handling of tier states when decoding from the URL. The logic now incorporates early returns for cases where the state is absent or the decodedState is invalid, thereby improving error handling. The labelPosition is consistently applied to each tier during updates, and the dependency array of the useEffect hook has been modified to include labelPosition, allowing for dynamic updates based on state changes.

Changes

File	Change Summary
components/TierListManager.tsx	Improved error handling for URL state decoding, ensured consistent application of labelPosition during updates, and modified useEffect dependency array to include labelPosition for dynamic updates.

Poem

🐰 In the realm of tiers and state divine,
A rabbit's code now aligns just fine!
Label positions dance and sway,
With URL's whispers, they find their way
Synchronicity, oh so neat! 🏷️

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57cca20 and 7635e63.

📒 Files selected for processing (1)

• components/TierListManager.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• components/TierListManager.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
opentierboy	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 28, 2024 0:18am

[infinia-yzl]

Thanks for spotting and fixing this.