asset(image-supervive): Add SUPERVIVE image template #109
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request introduces several updates across multiple files. A new funding source for the project is added to Changes
Assessment against linked issues
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
imageset.custom.json (1)
25-27: Consider adding a googleFont property for consistencyOther game entries like "THE FINALS" and "WUTHERING WAVES" specify a custom
googleFont. Consider whether "SUPERVIVE" should also have a specific font to maintain visual consistency with its branding.CONTRIBUTING.md (1)
34-35: Improve accessibility by properly formatting URLs.The bare URLs should be formatted as markdown links for better accessibility and consistency with markdown best practices.
Apply this change:
-- Webdev (image-webdev): https://github.com/infinia-yzl/image-webdev -- Supervive (image-supervive): https://github.com/infinia-yzl/image-supervive +- Webdev (image-webdev): [https://github.com/infinia-yzl/image-webdev](https://github.com/infinia-yzl/image-webdev) +- Supervive (image-supervive): [https://github.com/infinia-yzl/image-supervive](https://github.com/infinia-yzl/image-supervive)🧰 Tools
🪛 Markdownlint
34-34: null
Bare URL used(MD034, no-bare-urls)
35-35: null
Bare URL used(MD034, no-bare-urls)
imageset.config.json (1)
2151-2186: Consider adding version and rarity tags for future updates.While the current tag structure is good, consider future-proofing by:
- Adding version tags (e.g., "v1_0_0") to track character releases
- Including rarity/tier tags if characters have different ranks or tiers
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (8)
.github/FUNDING.yml(1 hunks).idea/misc.xml(1 hunks)CONTRIBUTING.md(1 hunks)app/layout.tsx(4 hunks)app/page.tsx(1 hunks)imageset.config.json(1 hunks)imageset.custom.json(1 hunks)package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- .github/FUNDING.yml
- .idea/misc.xml
🧰 Additional context used
🪛 Markdownlint
CONTRIBUTING.md
34-34: null
Bare URL used
(MD034, no-bare-urls)
35-35: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (12)
imageset.custom.json (1)
25-27: Verify the background image asset exists
The new entry references a background image at /splash/supervive-keyart.webp. Let's verify this asset exists and is properly optimized.
✅ Verification successful
Background image asset verified and optimized
The referenced image /splash/supervive-keyart.webp exists in the correct location and is well-optimized at 66KB, which is a reasonable size for a webp splash image.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence and optimization of the SUPERVIVE background image
# Check if the image file exists in the public/splash directory
fd "supervive-keyart.webp" public/splash
# If found, check the file size to ensure it's optimized
if [ $? -eq 0 ]; then
find public/splash -name "supervive-keyart.webp" -exec ls -lh {} \;
fi
Length of output: 249
package.json (2)
48-48: LGTM! Dependency addition follows established pattern
The new dependency image-supervive follows the same pattern as other image sets in the project (e.g., image-overwatch, image-reachthefinals).
48-48: Verify the package version
Let's ensure we're using the most appropriate version of the package.
✅ Verification successful
Package version is appropriate
The current version 1.0.2 is the latest available version of image-supervive. The package was recently published (November 18, 2024) and has minimal dependencies (@inquirer/prompts). The version being used in the project is up-to-date.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check npm registry for latest version and release info
# Get latest version and release info
npm view image-supervive versions --json
# Check install size and dependencies
npm view image-supervive size
npm view image-supervive dependencies --json
# Check weekly downloads for stability indication
npm view image-supervive downloads --json
Length of output: 237
Script:
#!/bin/bash
# Let's check when these versions were published and any potential issues
npm view image-supervive time --json
# Also check the package.json in the repository to see if this dependency is used
rg -l "image-supervive" --type json
Length of output: 350
Script:
#!/bin/bash
# Let's check how this package is being used in the config files
cat imageset.config.json imageset.custom.json
# And check if there are any scripts in package.json using this package
cat package.json | jq '.scripts'
Length of output: 50019
app/page.tsx (1)
14-14: LGTM! Verify tag consistency with image configurations.
The new FEATURED_SETS entry follows the established pattern and integrates well with the existing code structure.
Let's verify that the tags match the configured images:
✅ Verification successful
All tags in FEATURED_SETS are properly configured and used in image metadata
The verification shows that:
- All tags (
hunter,fighter,initiator,frontliner,protector,controller) are properly defined in theimageset.config.jsonconfiguration - Each tag has proper metadata (title, description, category)
- The tags are actively used in image metadata across multiple character entries
- The configuration is consistent between
imageset.config.jsonandimageset.custom.json
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the tags in FEATURED_SETS match the image configurations
# Check if the package and its tags are properly configured in imageset.config.json
jq '.packages."image-supervive"' imageset.config.json
# Check if the custom configuration exists
jq '.packages."image-supervive"' imageset.custom.json
# Verify if all the tags have corresponding images
for tag in "hunter" "fighter" "initiator" "frontliner" "protector" "controller"; do
echo "Checking images for tag: $tag"
find . -path "*/image-supervive/*" -type f -name "*${tag}*.png" -o -name "*${tag}*.jpg" -o -name "*${tag}*.jpeg"
done
Length of output: 5438
CONTRIBUTING.md (1)
34-35: LGTM! Verifying repository links.
The new image sets are properly documented following the existing pattern.
Let's verify the accessibility of the new repository links:
✅ Verification successful
Repository links are accessible and public
Both new repositories exist and are publicly accessible:
image-webdev: Public repository with descriptionimage-supervive: Public repository (though missing description)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if the new repository URLs are accessible
# Expected: Both repositories should exist and be public
for repo in "image-webdev" "image-supervive"; do
echo "Checking $repo..."
gh repo view "infinia-yzl/$repo" --json name,isPrivate,description
done
Length of output: 583
🧰 Tools
🪛 Markdownlint
34-34: null
Bare URL used
(MD034, no-bare-urls)
35-35: null
Bare URL used
(MD034, no-bare-urls)
app/layout.tsx (4)
5-5: LGTM: Next.js Link import added correctly
The import is properly placed and necessary for the Link component usage throughout the file.
158-170: LGTM: Header navigation properly migrated to Next.js Link components
The migration from anchor tags to Next.js Link components is well-implemented:
- Proper nesting of Link components
- Correct usage of Button's asChild prop
- Preserved styling and accessibility attributes
197-199: LGTM: Footer navigation properly migrated to Next.js Link components
The migration is well-implemented with proper consideration for:
- Internal routes using Next.js Link components
- External email link remaining as anchor tag
- Preserved styling and layout structure
Also applies to: 230-231
158-170: Verify navigation paths for new SUPERVIVE content
Since this PR adds SUPERVIVE image templates, let's verify that all necessary navigation paths are in place.
Also applies to: 197-199, 230-231
✅ Verification successful
Let me verify the navigation paths by checking the actual content and routes.
Navigation paths are properly configured and aligned with content
The verification confirms that:
- All navigation paths in the layout (
/,/about,/blog) have corresponding routes in the app directory - SUPERVIVE content is properly integrated in the homepage (
app/page.tsx) as one of the featured image sets - The navigation structure supports both the existing content and the new SUPERVIVE templates
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify navigation paths for SUPERVIVE content
# Check for any SUPERVIVE-related route definitions
echo "Checking for SUPERVIVE route definitions..."
rg -l "supervive" app/
# Check for any potential broken internal links
echo "Checking for potential broken internal links..."
fd -e tsx -e ts | xargs rg -l "href=\"/"
Length of output: 454
Script:
#!/bin/bash
# Check the content of page.tsx for SUPERVIVE-related routes
echo "Content of app/page.tsx:"
cat app/page.tsx
# Check if all linked routes exist
echo -e "\nVerifying routes mentioned in layout.tsx:"
for route in "/" "/about" "/blog"; do
if fd "^${route#/}$|^${route#/}/" app/; then
echo "✓ Route $route exists"
else
echo "✗ Route $route not found"
fi
done
Length of output: 3581
imageset.config.json (3)
2003-2004: LGTM: Package addition follows established patterns.
The new "image-supervive" package is correctly structured and follows the same organization pattern as other game-related packages.
2005-2150: LGTM: Well-structured image entries with consistent tagging.
The image entries follow a consistent pattern with:
- Clear 3-letter filename codes
- Descriptive labels in uppercase
- Appropriate role-based tags
- Proper event tagging for the open beta launch
2188-2188: LGTM: Background image follows naming convention.
The background image path follows the established pattern of using keyart for splash backgrounds.
Fixes: #108
Description
Adds SUPERVIVE images by Theorycraft Games (https://playsupervive.com).
Screenshots
Checklist:
Additional context
Includes misc changes & funding.yml.
Summary by CodeRabbit
Release Notes
New Features
Linkcomponents for improved routing.Bug Fixes