Renaming messages #130
Merged
Renaming messages #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ineiti
commented
Oct 14, 2024
•
ineiti
commented
- The wrapper of module messages gets renamed from NodeMessage to NetworkWrapper
- The messages between the same modules of two different nodes gets renamed from MessageNode and others to ModuleMessage
- Renamed some of the NetworkIn and NetworkOut messages
ineiti
force-pushed
the
rename_nodemessage
branch
2 times, most recently
from
c228750 to
e4fcdc5
Compare
- The wrapper of module messages gets renamed from NodeMessage to NetworkWrapper - The messages between the same modules of two different nodes gets renamed from MessageNode and others to ModuleMessage - Renamed some of the NetworkIn and NetworkOut messages
ineiti
force-pushed
the
rename_nodemessage
branch
from
e4fcdc5 to
638061b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.