-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add create3 predeploys #320
base: develop
Are you sure you want to change the base?
fix: add create3 predeploys #320
Conversation
There are 2 versions of ZeframLou's CREATE3 predeploys: - the first is deployed using a private key controlled by the deployer and a nonce of 0 - the second is deployed using CREATE2 and a salt of bytes32(0) While the second can be deployed by us manually, the first can cannot. Hence, add it manually. For ease of use, add both.
WalkthroughThe change extends the predeploy system by adding two new predeploy contracts, Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (2)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. LGTM.
There are 2 versions of ZeframLou's CREATE3 predeploys:
While the second can be deployed by us manually, the first can cannot. Hence, add it manually. For ease of use, add both.
Summary by CodeRabbit