Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add create3 predeploys #320

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MaxMustermann2
Copy link
Contributor

@MaxMustermann2 MaxMustermann2 commented Feb 27, 2025

There are 2 versions of ZeframLou's CREATE3 predeploys:

  • the first is deployed using a private key controlled by the deployer and a nonce of 0
  • the second is deployed using CREATE2 and a salt of bytes32(0)

While the second can be deployed by us manually, the first can cannot. Hence, add it manually. For ease of use, add both.

Summary by CodeRabbit

  • New Features
    • Advanced contract deployment options are now available at genesis. Two distinct deployment modes provide enhanced flexibility, including deterministic deployment for predictable contract addresses. This update expands native deployment capabilities, ensuring seamless integration while preserving existing functionalities and compatibility. Users will benefit from more robust contract management and improved support for advanced integration scenarios.

There are 2 versions of ZeframLou's CREATE3 predeploys:
- the first is deployed using a private key controlled by the deployer
  and a nonce of 0
- the second is deployed using CREATE2 and a salt of bytes32(0)

While the second can be deployed by us manually, the first can cannot.
Hence, add it manually. For ease of use, add both.
Copy link
Contributor

coderabbitai bot commented Feb 27, 2025

Walkthrough

The change extends the predeploy system by adding two new predeploy contracts, create3 and create3Deterministic. Both are defined with specific addresses and bytecode in the x/evm/types/predeploys.go file. These entries are appended to the DefaultPredeploys list without altering existing predeploys, ensuring the genesis configuration now supports extra contract functionality.

Changes

File Change Summary
x/evm/types/predeploys.go Added two new predeploy contracts: create3 and create3Deterministic to the DefaultPredeploys list.

Poem

I'm a rabbit with a twitching nose,
Hopping through code where new predeploys grow.
create3 and its deterministic friend join the ride,
Adding fresh magic to the genesis inside.
With every line, my heart does hop—
Celebrating fresh features that never stop!
🥕🐰 Enjoy the code, it's time to pop!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd50583 and 119f95b.

📒 Files selected for processing (1)
  • x/evm/types/predeploys.go (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: test-unit-e2e
  • GitHub Check: test-unit-cover
  • GitHub Check: Run golangci-lint
  • GitHub Check: goreleaser
  • GitHub Check: Analyze (go)
🔇 Additional comments (2)
x/evm/types/predeploys.go (2)

32-33: LGTM! Correctly adds new predeploys to the list.

The addition of create3 and create3Deterministic to the DefaultPredeploys list is properly done and keeps the existing pattern of comma-separated list entries.


106-116: Well-structured implementation of CREATE3 predeploys.

The implementation adds two versions of ZeframLou's CREATE3 contract as predeploys:

  1. The first version at address 0x9fBB3DF7C40Da2e5A0dE984fFE2CCB7C47cd0ABf was deployed using a known deployer address and nonce 0
  2. The second version at address 0x6aa3d87e99286946161dca02b97c5806fc5ed46f was deployed using CREATE2 with a salt of bytes32(0)

Both implementations follow the project's established pattern for predeploys and include proper documentation in the comments. The bytecode looks valid and will be validated at initialization time by the init() function.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@bwhour bwhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants