refactor(dogfood): prepare for app addition
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, our prior work around of storing a subset of the header fields for HistoricalInfo can only work for the IBC usage. The EVM module requires the full header to be stored so that it can calculate its hash and that of older blocks to respond to the `blockhash` calls within Solidity.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MaxMustermann2
requested review from
rlan35,
bwhour,
trestinlsd,
mikebraver,
TimmyExogenous and
leonz789
bwhour
approved these changes
Apr 10, 2024
TimmyExogenous
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key additions include:
7e48c12 feat(dogfood): implement export validators: A function to
ExportValidatorsof thetmtypes.GenesisValidatorvariety, for use inapp/export.goafb785c fix(dogfood): implement erc20 interface:
x/erc20requires theBondDenominterface to decide whether a token's denomination is the native token. If so, theerc20module does not handle it.77b7e84 fix(dogfood): move hooks to types: Now that all of the hooks are defined in their respective modules, remove the definitions from
expected_keepers.goa97ee28 fix(dogfood): implement panicky gov interface: The
govmodule for our network could potentially be different from other networks, since we want holders of our tokens to participate in governance and not just validator operators. This PR implements an interface required by the governance module, panicking on each call.cc1413b refactor(dogfood): store full header not subset: Unfortunately, our prior planning of reducing the storage required by this module by using a validator set ID (and height to ID mapping) to create the
HistoricalInfois not good enough. This is because thex/evmmodule pulls the past headers hash from the staking keeper (to respond to theblockhashcall), which requires the full header and not just a subset.acbcd3c fix(dogfood): implement the evm expected interface: Allow fetching of proposer's
AccAddressto determine the coinbase.