Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused ginkgo #18

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

leonz789
Copy link
Contributor

Description

refactor
currently this project mainly use testify as test framework, ginkgo is unused with empty entry point left.


Closes #XXX

Copy link
Contributor

@TimmyExogenous TimmyExogenous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mikebraver mikebraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebraver
Copy link
Contributor

mikebraver commented Apr 11, 2024

Please resolve branch conflict and then can be merged

@leonz789 leonz789 force-pushed the develop-leon-refactor branch from c646504 to 9553843 Compare April 12, 2024 06:08
@mikebraver mikebraver merged commit 458ffd9 into imua-xyz:develop Apr 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants