From f266371b4e9652415f5ff3b0e9a6c12c067aeb47 Mon Sep 17 00:00:00 2001
From: MaxMustermann2 <82761650+MaxMustermann2@users.noreply.github.com>
Date: Wed, 3 Apr 2024 15:02:27 +0000
Subject: [PATCH] test(assets): require both malleate + unmalleate

---
 x/assets/types/genesis_test.go | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/x/assets/types/genesis_test.go b/x/assets/types/genesis_test.go
index 6b5052b65..76f863364 100644
--- a/x/assets/types/genesis_test.go
+++ b/x/assets/types/genesis_test.go
@@ -165,6 +165,9 @@ func (suite *GenesisTestSuite) TestValidateGenesis() {
 			malleate: func(gs *types.GenesisState) {
 				gs.Tokens[0].StakingTotalAmount = math.NewInt(1)
 			},
+			unmalleate: func(gs *types.GenesisState) {
+				gs.Tokens[0].StakingTotalAmount = math.NewInt(0)
+			},
 		},
 		{
 			name: "invalid genesis due to negative supply amount for token",
@@ -201,6 +204,9 @@ func (suite *GenesisTestSuite) TestValidateGenesis() {
 			malleate: func(gs *types.GenesisState) {
 				gs.Deposits[0].StakerID = strings.ToUpper(gs.Deposits[0].StakerID)
 			},
+			unmalleate: func(gs *types.GenesisState) {
+				gs.Deposits[0].StakerID = strings.ToLower(gs.Deposits[0].StakerID)
+			},
 		},
 		{
 			name: "invalid genesis due to invalid staker id",
@@ -218,6 +224,9 @@ func (suite *GenesisTestSuite) TestValidateGenesis() {
 			malleate: func(gs *types.GenesisState) {
 				gs.Deposits[0].StakerID = "fakeStaker"
 			},
+			unmalleate: func(gs *types.GenesisState) {
+				gs.Deposits[0].StakerID = stakerID
+			},
 		},
 		{
 			name: "invalid genesis due to staker id from unknown chain",
@@ -235,6 +244,9 @@ func (suite *GenesisTestSuite) TestValidateGenesis() {
 			malleate: func(gs *types.GenesisState) {
 				gs.Deposits[0].StakerID = "fakeStaker_0x63"
 			},
+			unmalleate: func(gs *types.GenesisState) {
+				gs.Deposits[0].StakerID = stakerID
+			},
 		},
 		{
 			name: "invalid genesis due to non hex staker id",
@@ -252,6 +264,9 @@ func (suite *GenesisTestSuite) TestValidateGenesis() {
 			malleate: func(gs *types.GenesisState) {
 				gs.Deposits[0].StakerID = "fakeNonHexStaker_0x65"
 			},
+			unmalleate: func(gs *types.GenesisState) {
+				gs.Deposits[0].StakerID = stakerID
+			},
 		},
 		{
 			name: "invalid genesis due to duplicate staker id",
@@ -306,6 +321,9 @@ func (suite *GenesisTestSuite) TestValidateGenesis() {
 					genesisDeposit.Deposits[0],
 				)
 			},
+			unmalleate: func(gs *types.GenesisState) {
+				gs.Deposits[0].Deposits = gs.Deposits[0].Deposits[:1]
+			},
 		},
 		{
 			name: "invalid genesis due to nil values for staker",
@@ -449,6 +467,8 @@ func (suite *GenesisTestSuite) TestValidateGenesis() {
 		tc := tc
 		if tc.malleate != nil {
 			tc.malleate(tc.genState)
+			// check that unmalleate is not nil
+			suite.Require().NotNil(tc.unmalleate, tc.name)
 		}
 		err := tc.genState.Validate()
 		if tc.expPass {