Skip to content

refactor(oracle): introduce FeederManager to replace aggregator and caches for transaction handling #1465

refactor(oracle): introduce FeederManager to replace aggregator and caches for transaction handling

refactor(oracle): introduce FeederManager to replace aggregator and caches for transaction handling #1465

Triggered via pull request January 12, 2025 17:58
Status Failure
Total duration 1m 6s
Artifacts

lint.yml

on: pull_request
Run golangci-lint
56s
Run golangci-lint
Run markdown-lint
9s
Run markdown-lint
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 7 warnings
Run golangci-lint: x/oracle/keeper/feedermanagement/feedermanager.go#L637
Error return value of `r.Tally` is not checked (errcheck)
Run golangci-lint: x/oracle/keeper/feedermanagement/algo.go#L73
assignOp: replace `price.Price = price.Price + strings.Repeat("0", a.decimal-int(price.Decimal))` with `price.Price += strings.Repeat("0", a.decimal-int(price.Decimal))` (gocritic)
Run golangci-lint: x/oracle/keeper/feedermanagement/prices.go#L193
File is not `gofumpt`-ed (gofumpt)
Run golangci-lint: x/oracle/keeper/feedermanagement/types.go#L195
File is not `gofumpt`-ed (gofumpt)
Run golangci-lint: x/oracle/keeper/feedermanagement/types.go#L203
File is not `gofumpt`-ed (gofumpt)
Run golangci-lint: x/oracle/keeper/feedermanagement/prices.go#L88
`independetly` is a misspelling of `independently` (misspell)
Run golangci-lint: x/oracle/keeper/feedermanagement/types.go#L80
`independetly` is a misspelling of `independently` (misspell)
Run golangci-lint: x/oracle/keeper/feedermanagement/types.go#L87
`requred` is a misspelling of `required` (misspell)
Run golangci-lint: x/oracle/keeper/msg_server_create_price.go#L83
`udpated` is a misspelling of `updated` (misspell)
Run golangci-lint: x/oracle/keeper/feedermanagement/caches.go#L209
unnecessary conversion (unconvert)
Run markdown-lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Run golangci-lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Run golangci-lint: x/oracle/keeper/feedermanagement/algo.go#L86
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
Run golangci-lint: x/oracle/keeper/feedermanagement/caches.go#L54
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
Run golangci-lint: x/oracle/keeper/feedermanagement/prices.go#L42
unexported-return: exported func GetPriceSourceFromProto returns unexported type *feedermanagement.priceSource, which can be annoying to use (revive)
Run golangci-lint: x/oracle/keeper/feedermanagement/feedermanager.go#L553
unused-parameter: parameter 'msg' seems to be unused, consider removing or renaming it as _ (revive)
Run golangci-lint: x/oracle/keeper/feedermanagement/feedermanager.go#L28
unexported-return: exported method GetCaches returns unexported type *feedermanagement.caches, which can be annoying to use (revive)