Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support multiple client chains (Sepolia/Holesky) in configuration #147

Open
coderabbitai bot opened this issue Feb 6, 2025 · 0 comments
Assignees

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2025

Background

Currently, the configuration in deployedContracts.json uses a generic clientChain key for Sepolia network addresses. With the addition of Holesky network support, we need to refactor this to clearly distinguish between different networks.

Required Changes

  1. Rename clientChain key to sepolia in deployedContracts.json for better clarity
  2. Update all scripts that reference the clientChain configuration
  3. Modify CI workflows to support both networks
  4. Add environment variable support to control which network to use during deployment and testing

References

Discussion: //pull/145#discussion_r1943990000

Notes

  • This change will require coordination across multiple scripts and CI configurations
  • Consider using an environment variable like NETWORK=sepolia|holesky to control which network to use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant