Fix: Strauss directory permissions #7647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonTheAdams
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Appreciate the workaround, @defunctl!
Let's hold on merging this for a day or two to see if Brian accepts and merges your fix in Strauss. If it's looking like it may take some time, we'll merge.
|
@JasonTheAdams no worries, you'll definitely want to add this to your existing PR if you don't merge this one.
|
|
@defunctl thank you!!! 😭 |
@jonwaldstein exactly! |
|
Excited for the quick turnaround! Thanks for submitting the Strauss fix, @defunctl! 🌮 Closing in favor of the new fix direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have A PR into Strauss to fix the permissions here: BrianHenryIE/strauss#130
Until that's merged and released, this should work to fix things in your workflows.
Successful Job Here: https://github.com/impress-org/givewp/actions/runs/12285568512