format: run rg --files --type c --type cpp --glob '!external/' | xags clang-format -i
#518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks to have broken |
Oh weird, it worked fine locally. I'll fix it later at some point, not too important if it's not trivial. |
kkysen
force-pushed
the
kkysen/clang-format
branch
from
b67eac5 to
9567b6b
Compare
…gs clang-format -i` A lot of files aren't formatted correctly, so whenever I edit files and format, it adds a lot of extra formatting fixes, which makes PRs much harder to review with all of this extraneous info. We should probably add this to CI/pre-commit hook, but this should be enough for now. This also adds `AllowShortBlocksOnASingleLine: Always` to `.clang-format`, as this is needed to keep LLVM `lit` tests still working.
kkysen
force-pushed
the
kkysen/clang-format
branch
from
9567b6b to
f039543
Compare
|
I'd like to wait until other PRs land before we merge this, since it'll create a lot of conflicts. There are also some formatting decisions that clang-format makes here that really destroy readability, mostly around macros. Can we ask clang-format not to alter macro definitions? E.g. see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of files aren't formatted correctly, so whenever I edit files and format, it adds a lot of extra formatting fixes, which makes PRs much harder to review with all of this extraneous info.
We should probably add this to CI/pre-commit hook, but this should be enough for now.
This is a more complete fix to #516, which was getting in the way of reviewing #514.