From da26807c21c70d735ed84376386ecdc99020690a Mon Sep 17 00:00:00 2001 From: Khyber Sen Date: Mon, 16 Dec 2024 02:43:23 -0800 Subject: [PATCH] rewriter: error on arm if we try to use a post condition function, which isn't supported yet This is a fatal error (ICE) since the caller can just set `--no-enable-dav1d_get_picture-post-condition`. --- tools/rewriter/GenCallAsm.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/rewriter/GenCallAsm.cpp b/tools/rewriter/GenCallAsm.cpp index 5aac93ffc4..5f898be0cc 100644 --- a/tools/rewriter/GenCallAsm.cpp +++ b/tools/rewriter/GenCallAsm.cpp @@ -494,6 +494,10 @@ static void emit_prologue(AsmWriter &aw, uint32_t caller_pkey, uint32_t target_p // TODO(performance): We could store by pairs (STP) add_asm_line(aw, "str "s + aarch64_preserved_registers[i] + ", [sp, #" + std::to_string(i * 8) + "]"); } + + if (save_param_regs) { + llvm::report_fatal_error("--enable-dav1d_get_picture-post-condition is not yet supported on aarch64"); + } } }