Add 4C thermo elements to cubitpy #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely makes sense! Maybe we should split the element type from the physical field in the future, but that is definitely beyond the scope of this PR. Could you add a short test case for this, similar to the |
|
@isteinbrecher Will look at the test case at some point. |
|
@isteinbrecher Any idea why testing fails? |
|
Do they pass locally on your system? |
|
No ;) |
|
@isteinbrecher Testing passes now. I also added some things for scatra ... |
isteinbrecher
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently thermo elements are missing in the 4C .dat file creation procedure. This PR adds the missing branches and return values. In addition a small bug regarding a fluid element branch is fixed.