Add correction factors for pressure-based Green function #90
Conversation
src/mirco_setparameters.cpp
Outdated
| // The following pressure based constants are calculated by solving a flat indentor problem using | ||
| // the pressure based Green function described in Pohrt and Li (2014). | ||
| // http://dx.doi.org/10.1134/s1029959914040109 | ||
| std::vector<double> alpha_con_pressure{0.961389237917602, 0.924715342432435, 0.899837531880697, |
There was a problem hiding this comment.
What does alpha_con stand for?
Also, you can make these vectors const.
There was a problem hiding this comment.
This variable name has not been changed since the beginning. The Greek letter alpha is used in Section 3.3 of https://doi.org/10.1007/s00466-019-01791-3 to denote this variable. These are called "shape factors". Once we have the shape factors, the Elastic compliance correction can be calculated as done in line 89 of the mirco_set_parameters.cpp. I will rename this variable for a better readability of the code.
src/mirco_setparameters.cpp
Outdated
| // The following pressure based constants are calculated by solving a flat indentor problem using | ||
| // the pressure based Green function described in Pohrt and Li (2014). | ||
| // http://dx.doi.org/10.1134/s1029959914040109 | ||
| std::vector<double> alpha_con_pressure{0.961389237917602, 0.924715342432435, 0.899837531880697, |
There was a problem hiding this comment.
| std::vector<double> alpha_con_pressure{0.961389237917602, 0.924715342432435, 0.899837531880697, | |
| const std::vector<double> alpha_con_pressure{0.961389237917602, 0.924715342432435, 0.899837531880697, |
src/mirco_setparameters.cpp
Outdated
| 0.882669916668780}; | ||
| // The following force based constants are taken from Table 1 of Bonari et al. (2020). | ||
| // https://doi.org/10.1007/s00466-019-01791-3 | ||
| std::vector<double> alpha_con_force{0.778958541513360, 0.805513388666376, 0.826126871395416, |
There was a problem hiding this comment.
| std::vector<double> alpha_con_force{0.778958541513360, 0.805513388666376, 0.826126871395416, | |
| const std::vector<double> alpha_con_force{0.778958541513360, 0.805513388666376, 0.826126871395416, |
|
@isteinbrecher @mayrmt FYI Since MIRCO currently consumes a lot of memory and time to solve high-resolution problems with large contact area percentages (in this case: flat indenters), our MATLAB-based bem-code is used to calculate these factors. |
Yes, you are right. It is not mentioned here, but currently, MIRCO works only from the resolution of 1 to 8. (2^n+1 times 2^n+1 nodes grid) |
| // These are the shape factors to calculate the elastic compliance correction of the micro-scale | ||
| // contact constitutive law for various resolutions. | ||
| // NOTE: Currently MIRCO works for resouluion of 1 to 8. The following vectors store the shape | ||
| // factors for resolution of 1 to 8. |
There was a problem hiding this comment.
Alternatively you could use a map here, something like
const std::map<int, double> shape_factors_presure{{1,0.961389237917602},{2,0.924715342432435},...};Then you can access the data with shape_factors_pressure[Resolution] instead of shape_factors_pressure[Resolution - 1], i.e., you map a resolution value to a pressure.
There was a problem hiding this comment.
I like the map proposal. It makes the assignment of resolution to the value very explicit.
Description and Context
In PR #87, The pressure-based Green function was added. In this PR, the correction factors corresponding to the pressure-based Green function are added.
These values are calculated by using MIRCO to solve a contact between a linear elastic half-plane and a rigid flat-indenter.
Related Issues and Pull Requests
How Has This Been Tested?
ctestis passingChecklist
Additional Information
Interested Parties / Possible Reviewers
@isteinbrecher @mayrmt