Merge pull request #92 from sebproell/clang-warnings

Fix two warnings when compiling with Clang
imcs-compsim · Mar 25, 2024 · a369329 · a369329
2 parents 8a8ae9c + f020956
commit a369329
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/mirco_topology.cpp b/src/mirco_topology.cpp
@@ -22,7 +22,7 @@ void MIRCO::ReadFile::GetSurface(Teuchos::SerialDenseMatrix<int, double> &z)
   }
   reader.close();
   z.shape(dimension, dimension);
-  int position = 0, separatorPosition, lineCounter = 0;
+  int separatorPosition, lineCounter = 0;
   std::ifstream stream(TopologyFilePath);
   std::string line, container;
   double value;
@@ -34,7 +34,6 @@ void MIRCO::ReadFile::GetSurface(Teuchos::SerialDenseMatrix<int, double> &z)
     {
       separatorPosition = line.find_first_of(';');
       container = line.substr(0, separatorPosition);
-      position += 1;
       line = line.substr(separatorPosition + 1, line.length());
       value = stod(container);
       z(lineCounter - 1, i) = value;

diff --git a/src/mirco_topology.h b/src/mirco_topology.h
@@ -22,6 +22,8 @@ namespace MIRCO
      */
     virtual void GetSurface(Teuchos::SerialDenseMatrix<int, double> &z) = 0;
     TopologyGeneration(int nn) { resolution = nn; }
+
+    virtual ~TopologyGeneration() = default;
   };
 
   class ReadFile : public TopologyGeneration