Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Rust version to 1.34.2 #118

Merged
merged 2 commits into from
Nov 23, 2019
Merged

Conversation

kevinmehall
Copy link
Contributor

Tests have been failing for a while due to lack of support for 1.28 in rayon and its dependencies. This bumps the minimum Rust version to 1.34 to match the image crate.

Tests have been failing for a while due to lack of support for 1.28 in
rayon and its dependencies. This bumps the minimum version to 1.34 to
match the `image` crate.
Copy link

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also adjust README.md?

@LukasKalbertodt
Copy link

@kaksmet @fintelia could you have a look at this and #116 soon? Especially the later one is a pretty straight forward fix. Lots of crates across the Rust ecosystem depend on jpeg-decoder, so it would be really cool if both could be merged.

And I noticed that for a few months, no PRs were merged (i.e. this crate was unmaintained for a few months). I completely understand that there are tons of reasons for why one can't put any work into open source anymore. If you read this, could you consider getting the Rust Bus on board to help out in situations like these? Thanks :)

@fintelia fintelia merged commit 08fad3d into image-rs:master Nov 23, 2019
@fintelia
Copy link
Contributor

@LukasKalbertodt see image-rs/organization#9 for a bit of context. We now have image-rs:publish as a crate owner, so we should hopefully be able to stay more on top of PRs going forward

wartmanm pushed a commit to wartmanm/jpeg-decoder that referenced this pull request Oct 4, 2021
Bump minimum Rust version to 1.34.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants