[11.x] remove temporary variables (#53810)

* remove simple temporary variables

the declared variable is only used once. inlining does not decrease readability.

my guess is it was originally written this way *before* we had arrow functions, and could inherit the outer `$this` scope.

also minor formatting update to use our new multiline chaining standard

* revert

* inline some more simple variables

also put each argument on separate line for multiline for better git diffs

* remove more temporary variables

a couple more real simple ones

Access/Gate.php

@@ -836,12 +836,14 @@ protected function formatAbilityToMethod($ability)
      */
     public function forUser($user)
     {
-        $callback = fn () => $user;
-
         return new static(
-            $this->container, $callback, $this->abilities,
-            $this->policies, $this->beforeCallbacks, $this->afterCallbacks,
-            $this->guessPolicyNamesUsingCallback
+            $this->container,
+            fn () => $user,
+            $this->abilities,
+            $this->policies,
+            $this->beforeCallbacks,
+            $this->afterCallbacks,
+            $this->guessPolicyNamesUsingCallback,
         );
     }
 

AuthManager.php

@@ -122,11 +122,9 @@ protected function callCustomCreator($name, array $config)
      */
     public function createSessionDriver($name, $config)
     {
-        $provider = $this->createUserProvider($config['provider'] ?? null);
-
         $guard = new SessionGuard(
             $name,
-            $provider,
+            $this->createUserProvider($config['provider'] ?? null),
             $this->app['session.store'],
             rehashOnLogin: $this->app['config']->get('hashing.rehash_on_login', true),
         );

CreatesUserProviders.php

@@ -63,9 +63,11 @@ protected function getProviderConfiguration($provider)
      */
     protected function createDatabaseProvider($config)
     {
-        $connection = $this->app['db']->connection($config['connection'] ?? null);
-
-        return new DatabaseUserProvider($connection, $this->app['hash'], $config['table']);
+        return new DatabaseUserProvider(
+            $this->app['db']->connection($config['connection'] ?? null),
+            $this->app['hash'],
+            $config['table'],
+        );
     }
 
     /**