Skip to content

Commit

Permalink
(fix): pin maturin version and always run CI (#65)
Browse files Browse the repository at this point in the history
* (fix): twine version

* (chore): now try without

* (fix): try checking twine version

* (fix): fowngrade to python 3.12 (hopefully can check against different interpreters

* (fix): pin maturin

* (chore): put python version back

* (chore): pin maturin in the right place

* (fix): run ci build + build-sdist on PRs
  • Loading branch information
ilan-gold authored Dec 2, 2024
1 parent 4ec5dc2 commit 1b69120
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
name: build on ${{ matrix.os }} (${{ matrix.target }}${{ matrix.os == 'linux' && format(' - {0}', matrix.manylinux == 'auto' && 'manylinux' || matrix.manylinux) || '' }})
# only run on push to tags, main branch, or explicit full build
# keep condition in sync with `build-sdist` job
if: github.ref_type == 'tag' || github.ref == 'refs/heads/main' || contains(github.event.pull_request.labels.*.name, 'Full Build')
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -50,6 +49,8 @@ jobs:
args: --release --out dist --interpreter '3.11 3.12 3.13'
rust-toolchain: stable
docker-options: -e CI
# https://github.com/PyO3/maturin/issues/2336#issuecomment-2507418846
maturin-version: 1.7.4
before-script-linux: |
# If we're running on rhel centos, install needed packages.
if command -v yum &> /dev/null; then
Expand All @@ -65,7 +66,6 @@ jobs:
build-sdist:
name: build sdist
# keep condition in sync with `build` job
if: github.ref_type == 'tag' || github.ref == 'refs/heads/main' || contains(github.event.pull_request.labels.*.name, 'Full Build')
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -74,6 +74,8 @@ jobs:
python-version: '3.13'
- uses: PyO3/maturin-action@v1
with:
# https://github.com/PyO3/maturin/issues/2336#issuecomment-2507418846
maturin-version: 1.7.4
command: sdist
args: --out dist
rust-toolchain: stable
Expand Down

0 comments on commit 1b69120

Please sign in to comment.