-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up CI & miscellaneous updates for 3.10 #911
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
========================================
+ Coverage 24.0% 95.6% +71.6%
========================================
Files 48 48
Lines 4394 4394
========================================
+ Hits 1057 4204 +3147
+ Misses 3337 190 -3147 |
@glatterf42 while working on this, I noticed that we have some toctree entries in the documentation that do not appear in the rendered docs: Lines 138 to 140 in e0f2e02
This is because:
There is some good and useful text in these files, so I think they should be findable by people clicking around the documentation. Based on your understanding of GitHub (or more general) practices, can you clarify:
If yes to both, we can cope, but if no, then we I can very easily make sure they are integrated to the docs. |
Thanks, I read up in the docs:
No, they can be in the root directory,
Yes, I think so. In all examples and guides in GitHub's docs it is emphasized that the filename must be in all-caps and the ending While looking at the docs, I noticed that the community profile seems to not care about the |
- Drop old content: - Commented GAMS_VERSION. - Workaround for pyam-iamc exclusion of Python 3.13. - Narrow workaround for ts-graphviz/setup-graphviz#630. - Adjust 'tutorials' jobs parallel to #909, #910. - Simplify installation of reticulate. - Drop use of "remotes"; call install.packages() directly.
- mypy v1.12.0 → v1.14.1. - Drop custom hook entry that uses PRE_COMMIT_MYPY_VENV. - Use config suggested at python/mypy#13916. - ruff v0.8.4 → v0.9.1
- Copyedit some typos. - Reflow text.
Thanks. For the moment I tried to ensure all the contents are linked from the docs index, and also added direct links to the CoC and discussions to the docs sidebar. |
- Deduplicate text appearing in 3 input files. - Use current URLs for documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me :)
Parallel to iiasa/ixmp#555, plus:
How to review
PR checklist