Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and code quality #281

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Update CI and code quality #281

merged 5 commits into from
Jan 22, 2025

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Jan 21, 2025

How to review

@glatterf42:

  • Note that the CI checks all pass.
  • Read the diff for non-code files. (No need to review all the typing changes.)

All others: please ignore! Changes to type hints only.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation. N/A, CI changes only
  • Update doc/whatsnew.

@khaeru khaeru self-assigned this Jan 21, 2025
@khaeru khaeru force-pushed the ci/uv branch 3 times, most recently from fc1c845 to 67f5268 Compare January 22, 2025 07:40
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 95.52239% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.7%. Comparing base (c782c30) to head (080d9a5).

Files with missing lines Patch % Lines
message_ix_models/model/transport/ldv.py 81.8% 2 Missing ⚠️
message_ix_models/model/transport/report.py 66.6% 1 Missing ⚠️
message_ix_models/model/transport/workflow.py 0.0% 1 Missing ⚠️
message_ix_models/model/water/report.py 0.0% 1 Missing ⚠️
message_ix_models/report/__init__.py 80.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #281     +/-   ##
=======================================
- Coverage   77.6%   76.7%   -0.9%     
=======================================
  Files        211     211             
  Lines      16079   16108     +29     
=======================================
- Hits       12481   12363    -118     
- Misses      3598    3745    +147     
Files with missing lines Coverage Δ
...l/material/material_demand/material_demand_calc.py 88.3% <ø> (ø)
message_ix_models/model/transport/base.py 97.9% <100.0%> (ø)
message_ix_models/model/transport/config.py 97.6% <100.0%> (ø)
message_ix_models/model/transport/files.py 98.6% <100.0%> (+<0.1%) ⬆️
message_ix_models/model/transport/ikarus.py 85.3% <100.0%> (+0.1%) ⬆️
message_ix_models/model/transport/non_ldv.py 98.1% <100.0%> (ø)
message_ix_models/model/transport/operator.py 86.8% <100.0%> (+0.1%) ⬆️
message_ix_models/model/transport/plot.py 75.8% <100.0%> (ø)
message_ix_models/model/transport/roadmap.py 56.0% <ø> (ø)
message_ix_models/model/transport/testing.py 100.0% <100.0%> (ø)
... and 36 more

... and 7 files with indirect coverage changes

khaeru added a commit that referenced this pull request Jan 22, 2025
@khaeru khaeru added enh New features or functionality ci Continuous integration & testing labels Jan 22, 2025
@khaeru khaeru marked this pull request as ready for review January 22, 2025 13:27
Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. I love that we're type hinting more stuff :)

.github/workflows/pytest.yaml Show resolved Hide resolved
message_ix_models/tools/exo_data.py Outdated Show resolved Hide resolved
.github/workflows/pytest.yaml Outdated Show resolved Hide resolved
- Use env.python-version in both workflows.
- Run "pytest" on pull_request_target trigger to protect secrets; add
  "check permissions" job.
- Use defaults.shell.run to set bash shell.
- Rename env.gams → env.gams-version for clarity.
- mypy v1.13.0 → v1.14.0
  - Drop custom hook entry that uses PRE_COMMIT_MYPY_VENV.
  - Use config suggested at python/mypy#13916.
- ruff v0.7.4 → v0.9.1
  - Reformat 7 files.
@khaeru khaeru merged commit 3fe0467 into main Jan 22, 2025
1 of 2 checks passed
@khaeru khaeru deleted the ci/uv branch January 22, 2025 15:41
@glatterf42 glatterf42 mentioned this pull request Jan 23, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration & testing enh New features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants