-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI and code quality #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaeru
force-pushed
the
ci/uv
branch
3 times, most recently
from
January 22, 2025 07:40
fc1c845
to
67f5268
Compare
khaeru
added a commit
that referenced
this pull request
Jan 22, 2025
khaeru
added
enh
New features or functionality
ci
Continuous integration & testing
labels
Jan 22, 2025
khaeru
requested review from
adrivinca,
awais307,
r-aneeque,
GamzeUnlu95,
macflo8 and
glatterf42
as code owners
January 22, 2025 13:27
khaeru
removed request for
adrivinca,
awais307,
GamzeUnlu95,
macflo8 and
r-aneeque
January 22, 2025 13:28
glatterf42
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me. I love that we're type hinting more stuff :)
- Use env.python-version in both workflows. - Run "pytest" on pull_request_target trigger to protect secrets; add "check permissions" job. - Use defaults.shell.run to set bash shell. - Rename env.gams → env.gams-version for clarity.
- mypy v1.13.0 → v1.14.0 - Drop custom hook entry that uses PRE_COMMIT_MYPY_VENV. - Use config suggested at python/mypy#13916. - ruff v0.7.4 → v0.9.1 - Reformat 7 files.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.model.transport
.How to review
@glatterf42:
All others: please ignore! Changes to type hints only.
PR checklist
Add, expand, or update documentation.N/A, CI changes onlyUpdate doc/whatsnew.