Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wasm): fix missing CLI imports #99

Merged
merged 3 commits into from
Jun 4, 2024
Merged

fix(wasm): fix missing CLI imports #99

merged 3 commits into from
Jun 4, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented May 31, 2024 •
edited by julienrbrt
Loading

Close #98 #90

Description

Since we removed the import placeholders from Ignite CLI in v29 to use the xast pkg, the wasm app is no longer working. This PR moves the implementation to use xast and removes the goanalysis pkg from the app.

@Pantani Pantani self-assigned this May 31, 2024
julienrbrt
julienrbrt reviewed May 31, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog in wasm/CHANGELOG.md?

@Pantani Pantani requested a review from julienrbrt June 3, 2024 16:39
@Pantani Pantani enabled auto-merge (squash) June 3, 2024 19:36
@julienrbrt julienrbrt changed the title fix: fix missing CLI imports fix(wasm): fix missing CLI imports Jun 4, 2024
julienrbrt
julienrbrt approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

Keeps working on v28.x.y and now works on v29.x.y (main)

@Pantani Pantani merged commit c890b62 into main Jun 4, 2024
31 checks passed
@Pantani Pantani deleted the fix/wasm-scaffold branch June 4, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

Assignees

@Pantani Pantani

Labels
app:wasm ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasm app is not working with the next ignite version
2 participants
@Pantani @julienrbrt