Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: put hermes under root cmd #82

Merged
merged 2 commits into from
Apr 17, 2024
Merged

feat: put hermes under root cmd #82

merged 2 commits into from
Apr 17, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Apr 8, 2024

Description

since we are removing the ts-relayer, the ignite relayer command will not exist and will break the hermes app

salmad3
salmad3 previously approved these changes Apr 9, 2024
@julienrbrt
Copy link
Member

Cannot we do like we did for network?
This avoid CLI breaking changes and keeps the logic the same here. Otherwise we'll start to have different apps per Ignite version as well.

Alternatively, we could have a relayer no-op app in Ignite that is cobra hidden that just display to install the app when called.

@Pantani
Copy link
Collaborator Author

Pantani commented Apr 17, 2024

Cannot we do like we did for network? This avoid CLI breaking changes and keeps the logic the same here. Otherwise we'll start to have different apps per Ignite version as well.

Alternatively, we could have a relayer no-op app in Ignite that is cobra hidden that just display to install the app when called.

done on fbec985

@julienrbrt
Copy link
Member

Cool! But isn't it something we should do on ignite cli side instead?

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but i actually think the relayer command should be on ignite side (for backward compatibility)

@julienrbrt
Copy link
Member

Nvm, I see it in the other PR too.

@Pantani Pantani merged commit 2d86712 into main Apr 17, 2024
24 of 26 checks passed
@Pantani Pantani deleted the feat/relayer-cmd branch April 17, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants