-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add app-registry initial #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, just some suggestions but feel free to dismiss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @toschdev, left some suggestions, primarily nits and enhancements.
Thanks for all the comments, will try to address them. I really prefer commit suggestions because these are a lot of ideas to unpack. |
Adding a couple more, just for the record :) I would not use folders for the different app schemas unless we would have extra files per app, like pictures or documents, which might be better to avoid. That means all app schemas would be available at the same level under An alternative name for If we decide on the JSON schema idea we could defined the JSON schema as I would keep the schema as simple as possible with the minimum set of features we know are useful right now and maybe I would introduce more features "on demand" or as they are required. Inspiration could be found in other well stablished schemas: Nit: Maybe we could just use |
f3bb73e
to
1b5f2b0
Compare
Co-authored-by: Danny <salman.danny03@hotmail.com>
@jeronimoalbi @Pantani @julienrbrt bumping again, please re-review so that we can add the initial version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. we probably can always increment on this later.
Adds the App Registry within
ignite/apps/_ignite-app-registry
directory. With an example for theexplorer
Ignite App.It's expected that in the
_ignite-app-registry
, each app has it's own directory with an includingapp.json
in the format:appname/app.json
.Here's the
schema.app.json
: