Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix go.work file and run make format #54

Closed
wants to merge 2 commits into from
Closed

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Feb 1, 2024

No description provided.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go.work and go.work.sum shouldn't be committed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to commit go.work instead of go.work.example?

@Pantani
Copy link
Collaborator Author

Pantani commented Feb 2, 2024

@jeronimoalbi , @julienrbrt . We agree to not commit the go.work.sum. But why do we not commit to go.work?

And why keep the go.work.example if we are not using it?

@julienrbrt
Copy link
Member

julienrbrt commented Feb 2, 2024

@jeronimoalbi , @julienrbrt . We agree to not commit the go.work.sum. But why do we not commit to go.work?

And why keep the go.work.example if we are not using it?

go.work makes it easy for local development but it's going to make unclear what versions uses a program when tagging it (as the tagged version should depend on tagged version - like you should not tag something that depends on local replaces)

Keeping a go.work.example is handy for anyone using go.work, but when they submit a PR to the repo they need to make sure they only use released version, or split the PR.

There's a lengthy discussion about this in the SDK somewhere.

@Ehsan-saradar
Copy link
Contributor

Yep, @julienrbrt is right. This is also the case with ibc-go repository.

@Pantani Pantani closed this Feb 7, 2024
@Pantani Pantani deleted the chore/fix-go-work branch February 7, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants