-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update repository structure #50
Conversation
There are a couple of files that need merging but otherwise looks good 👍 |
I don't support the |
0469eea
to
2559038
Compare
7a96ad1
to
1964064
Compare
Can we not use the official folder? All apps will be official if we review and start to maintain them in our repo. If not approved, the user can use he's repository. wdyt @jeronimoalbi @ilgooz @julienrbrt? |
I totally get your point and actually had the same idea (and I still think it's more convenient). But, @ilgooz suggested this structure. |
@ilgooz, do we have any particular reason for the official directory? IMHO since the most of the team agree to not use, we can avoid the |
@toschdev also strongly agree in the structure |
@Pantani I'm thinking more about the user. Do we want them to type
where the second one is longer and also harder to remember. |
# Conflicts: # .github/workflows/test-integration.yml # official/explorer/go.sum # official/hermes/go.mod
100% agree with the above arguments. |
@julienrbrt I already made the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Description
official
directory and move the marketplace app to the root folder.app.ignite.yml
file, which contains the necessary information for the marketplace app to index applications inside this repository.go.work.example
.v28.2.0
.