Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update repository structure #50

Merged
merged 8 commits into from
Feb 16, 2024
Merged

feat: Update repository structure #50

merged 8 commits into from
Feb 16, 2024

Conversation

Ehsan-saradar
Copy link
Contributor

@Ehsan-saradar Ehsan-saradar commented Jan 30, 2024

Description

  1. Remove the official directory and move the marketplace app to the root folder.
  2. Add the app.ignite.yml file, which contains the necessary information for the marketplace app to index applications inside this repository.
  3. Update go.work.example.
  4. Bump ignite version to v28.2.0.

@jeronimoalbi
Copy link
Member

There are a couple of files that need merging but otherwise looks good 👍

@toschdev
Copy link
Contributor

toschdev commented Feb 5, 2024

I don't support the official directory. Every app listed in this repository should be considered official. But the extra directory clutters the namespace during installation. Community submissions should be expected to be hosted on designated accounts and repositories provided by them.

@Ehsan-saradar Ehsan-saradar enabled auto-merge (squash) February 12, 2024 08:15
@Ehsan-saradar Ehsan-saradar changed the title feat: Update Official App Templates feat: Update repository structure Feb 12, 2024
@Pantani
Copy link
Collaborator

Pantani commented Feb 14, 2024

Can we not use the official folder? All apps will be official if we review and start to maintain them in our repo. If not approved, the user can use he's repository.

wdyt @jeronimoalbi @ilgooz @julienrbrt?

@Ehsan-saradar
Copy link
Contributor Author

Can we not use the official folder? All apps will be official if we review and start to maintain them in our repo. If not approved, the user can use he's repository.

I totally get your point and actually had the same idea (and I still think it's more convenient). But, @ilgooz suggested this structure.

@Pantani
Copy link
Collaborator

Pantani commented Feb 15, 2024

Can we not use the official folder? All apps will be official if we review and start to maintain them in our repo. If not approved, the user can use he's repository.

I totally get your point and actually had the same idea (and I still think it's more convenient). But, @ilgooz suggested this structure.

@ilgooz, do we have any particular reason for the official directory? IMHO since the most of the team agree to not use, we can avoid the official folder

@Pantani
Copy link
Collaborator

Pantani commented Feb 15, 2024

Can we not use the official folder? All apps will be official if we review and start to maintain them in our repo. If not approved, the user can use he's repository.

I totally get your point and actually had the same idea (and I still think it's more convenient). But, @ilgooz suggested this structure.

@toschdev also strongly agree in the structure

@toschdev
Copy link
Contributor

@Pantani I'm thinking more about the user. Do we want them to type

ignite app install github.com/ignite/apps/hermes or
ignite app install github.com/ignite/apps/official/hermes

where the second one is longer and also harder to remember.
Every app in this repo should be considered official IMO

# Conflicts:
#	.github/workflows/test-integration.yml
#	official/explorer/go.sum
#	official/hermes/go.mod
@Pantani Pantani assigned Pantani and unassigned Ehsan-saradar Feb 16, 2024
@julienrbrt julienrbrt disabled auto-merge February 16, 2024 18:17
@julienrbrt
Copy link
Member

100% agree with the above arguments.

@Pantani
Copy link
Collaborator

Pantani commented Feb 16, 2024

100% agree with the above arguments.

@julienrbrt I already made the changes

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@Pantani Pantani merged commit 6f846a5 into main Feb 16, 2024
14 checks passed
@Pantani Pantani deleted the update/app-templates branch February 16, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants