Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simple spinner example app #170

Merged
merged 6 commits into from
Feb 25, 2025
Merged

feat: simple spinner example app #170

merged 6 commits into from
Feb 25, 2025

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Feb 23, 2025

I already created it to test the new spinner. IMHO, this is a good example of app

julienrbrt
julienrbrt approved these changes Feb 24, 2025
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I do not see any spinner:
https://asciinema.org/a/FPBT6AA8KgS1AZNZzGJzzewdR

@Pantani Pantani requested a review from julienrbrt February 25, 2025 13:22
@Pantani
Copy link
Collaborator Author

Pantani commented Feb 25, 2025

Actually, I do not see any spinner: https://asciinema.org/a/FPBT6AA8KgS1AZNZzGJzzewdR

Did you upgrade the dependency into the app spinner example? Pull the spinner branch and add it to go.mod before building the plugin.

replace ( github.com/ignite/cli/v29 => ../../../CLI )

@julienrbrt
Copy link
Member

image
If I replace everything to use ignite v29 in this app it works yes.

@julienrbrt julienrbrt merged commit 562a643 into main Feb 25, 2025
36 checks passed
@julienrbrt julienrbrt deleted the feat/spinner-example branch February 25, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants