Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce ignite cca #140

Merged
merged 13 commits into from
Jan 22, 2025
Merged

feat: introduce ignite cca #140

merged 13 commits into from
Jan 22, 2025

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Nov 15, 2024

Introduce an Ignite CCA app. It uses a modified version of the https://github.com/cosmology-tech/create-cosmos-app chain-admin template.

The modified version is what is being scaffolded on chains. There's a git patch to show exactly what changes between the original repo and the fork (basically mentioning ignite, deleting what we don't need, and configuring it to work with a local chain).

image

@julienrbrt julienrbrt changed the title feat: introduce ignite web feat: introduce ignite cca Nov 19, 2024
@julienrbrt julienrbrt marked this pull request as ready for review January 15, 2025 02:04
@julienrbrt
Copy link
Member Author

julienrbrt commented Jan 15, 2025

Needs ignite/cli#4466 and the v28.7.0 release.
In a follow-up we can introduce codegen with telescope :)

_registry/ignite.apps.cca.json Outdated Show resolved Hide resolved
cca/integration/app_test.go Show resolved Hide resolved
@julienrbrt julienrbrt requested a review from Pantani January 15, 2025 17:21
@Pantani
Copy link
Collaborator

Pantani commented Jan 22, 2025

thinking about in maintenance, is there any way for we don't keep this files into our repo? since is a copy and paste from other repo

@Pantani
Copy link
Collaborator

Pantani commented Jan 22, 2025

Screenshot 2025-01-22 at 17 37 27

the favicon is missing and shows a error when we click in the atomOne dropdown in the right

@julienrbrt
Copy link
Member Author

thinking about in maintenance, is there any way for we don't keep this files into our repo? since is a copy and paste from other repo

This is why we have a .patch, we can apply the patch: https://github.com/ignite/apps/pull/140/files#diff-33af196b7b0b2e38a3f05623330eae291241a55fa14282e8e710f57b2105f6e6. Thanks to this maintenance will be super easy.

@julienrbrt
Copy link
Member Author

Screenshot 2025-01-22 at 17 37 27

the favicon is missing and shows a error when we click in the dropdown

Very weird, I do not have this locally. Let me check

@julienrbrt
Copy link
Member Author

doing this in a follow-up to get the diff smaller

@julienrbrt julienrbrt merged commit 9906666 into main Jan 22, 2025
33 checks passed
@julienrbrt julienrbrt deleted the julien/web branch January 22, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants