chore: bump hermes binary to v1.10.0 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
|
Can we add a changelog entry? |
Pantani
changed the title
Pantani
changed the title
|
The unit tests are failing: https://github.com/ignite/apps/actions/runs/9749828095/job/26907870139?pr=114 |
julienrbrt
approved these changes
Jul 5, 2024
| @@ -16,18 +16,16 @@ type app struct{} | |||
|
|
|||
| func (app) Manifest(context.Context) (*plugin.Manifest, error) { | |||
| m := &plugin.Manifest{Name: "hermes"} | |||
| m.ImportCobraCommand(cmd.NewRelayer(), "ignite") | |||
| m.ImportCobraCommand(cmd.NewHermes(), "ignite relayer") | |||
There was a problem hiding this comment.
Won't this require changes on cli main again?
There was a problem hiding this comment.
Yes, I reverted because we need to launch a CLI version without the builtin relayer
There was a problem hiding this comment.
Yeah that makes sense. I think it's better like this as the app will stay compatible with v29 and v28. We should avoid breaking changes so it's great 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
channel-versionflag for the hermes create channel command;