Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "#type: ignore" to empty python enum types. Fixes #652 #663

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

susitsm
Copy link
Contributor

@susitsm susitsm commented Jan 20, 2025

The issue is caused by: https://github.com/python/mypy/blob/release-1.14/mypy/checker.py#L2602

There is no method to disable this exact lint, so I disabled type checking on the empty enum types. That fixes the issue.

There is another possible fix, without disabling type checking: we can emit all enum variants. That makes _iced_x86_py.pyi 7000 lines long, so I went with the cleaner one.

@wtfsck wtfsck merged commit 451a22d into icedland:master Jan 21, 2025
5 of 6 checks passed
@wtfsck
Copy link
Member

wtfsck commented Jan 21, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants