Use const generics to provide FastStrings #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Emann
force-pushed
the
const_generic_fast_string
branch
3 times, most recently
from
bbcbf8c to
928b6be
Compare
Also, use some `const` functions to improve the `mk_const_fast_str` macro, so the caller only has to include the string they care about, not the length or padding.
Dr-Emann
force-pushed
the
const_generic_fast_string
branch
from
928b6be to
9f55e1a
Compare
|
CI failed, unfortunately the GitHub Actions log shows only "error:" |
Dr-Emann
force-pushed
the
const_generic_fast_string
branch
from
87a35e6 to
c4f73e6
Compare
Some options aren't available for const yet in rust 1.57
Dr-Emann
force-pushed
the
const_generic_fast_string
branch
from
c4f73e6 to
26c4b03
Compare
|
Yeesh, finally passing |
wtfsck
approved these changes
Feb 25, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use some
constfunctions to improve themk_const_fast_strmacro, so the caller only has to include the string they care about, not the length or padding.