Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert UserList #575

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Convert UserList #575

merged 1 commit into from
Feb 19, 2025

Conversation

mshriver
Copy link
Contributor

No description provided.

@mshriver mshriver mentioned this pull request Feb 18, 2025
Draft
@mshriver mshriver force-pushed the userlist-3335 branch 2 times, most recently from 5195e11 to 905648e Compare February 18, 2025 18:28
@mshriver mshriver marked this pull request as ready for review February 18, 2025 18:28
@mshriver mshriver added enhancement New feature or request frontend labels Feb 18, 2025
@mshriver mshriver changed the title DRAFT convert UserList Convert UserList Feb 18, 2025
LightOfHeaven1994
LightOfHeaven1994 reviewed Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple suggestions about empty state (same as for projectList PR). Great work!

LightOfHeaven1994
LightOfHeaven1994 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshriver
Copy link
Contributor Author

Thanks @LightOfHeaven1994 !

@mshriver mshriver merged commit f5b80f8 into ibutsu:feature-react-functional Feb 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LightOfHeaven1994 LightOfHeaven1994 LightOfHeaven1994 approved these changes

@Fynardo Fynardo Awaiting requested review from Fynardo

Assignees
No one assigned
Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshriver @LightOfHeaven1994