Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert UserTokens #573

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

mshriver
Copy link
Contributor

syntax updates to AddTokenModal

simplification of tokens page, remove pagination from URL params

@mshriver mshriver added enhancement New feature or request frontend labels Feb 18, 2025
@mshriver mshriver force-pushed the userToken-3337 branch 2 times, most recently from fa33208 to ef10aaa Compare February 18, 2025 14:43
Copy link
Collaborator

@LightOfHeaven1994 LightOfHeaven1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, couple suggestions to fix empty state and loading state

@mshriver mshriver marked this pull request as draft February 19, 2025 13:56
@mshriver mshriver marked this pull request as ready for review February 19, 2025 14:07
syntax updates to AddTokenModal

simplification of tokens page, remove pagination from URL params
@mshriver mshriver merged commit a56b955 into ibutsu:feature-react-functional Feb 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants