Convert UserEdit to functional #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
force-pushed
the
useredit-convert-3334
branch
from
a03b0e0 to
179823e
Compare
mshriver
force-pushed
the
useredit-convert-3334
branch
4 times, most recently
from
f9a7fa6 to
8d53f2e
Compare
Change to FormSelect for Project selection
mshriver
force-pushed
the
useredit-convert-3334
branch
from
8d53f2e to
eb3c3aa
Compare
LightOfHeaven1994
approved these changes
Feb 18, 2025
| this.setState({ | ||
| filteredProjects: newSelectOptions, | ||
| }); | ||
| if (!isProjectsOpen){ |
There was a problem hiding this comment.
We don't need to have it in useEffect as MenuToggle handles it
There was a problem hiding this comment.
that's what I thought too, and I removed it, but the behavior wasn't right.
This pattern actually comes from the PF5 react example for multiselect typeahead with chips:
https://v5-archive.patternfly.org/components/menus/select#multiple-typeahead-with-chips
|
|
||
| render () { | ||
| const { projects, inputValue, filteredProjects, user, userProjects } = this.state; | ||
| }, [inputValue, projects, isProjectsOpen]); |
There was a problem hiding this comment.
isProjectsOpen can be removed from dependencies
There was a problem hiding this comment.
Only if I remove forcing it open when there is an input value present. ;)
There was a problem hiding this comment.
@mshriver oh I see, some specifics because of typeahead, then ignore my comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested well locally, field aren't validated in master right now and that would be a good follow up.
Also this could just be a modal instead of a separate page and route, with the ID as a prop.