-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location Groups July 2024 #1017
base: dev-flex-2024
Are you sure you want to change the base?
Location Groups July 2024 #1017
Conversation
fix: define and document MAP_BASE_URL to prevent gray maps
Excited for this update! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next round of comments...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleaning up the interim flex stuff and improving the types. I am going to give the benefit of doubt regarding the flow stuff. There are few nits but nothing fundamentally blocking.
@@ -863,6 +824,13 @@ export type GtfsLocation = {| | |||
zone_id?: string | |||
|} | |||
|
|||
// export type GtfsLocationGroup = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need it to show location groups on the map.
Location Group support following latest flex spec. Works with data tools-server
dev-flex
branch