-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-9392: Richtext editor menu is hidden below "ibexa-edit-header" #203
IBX-9392: Richtext editor menu is hidden below "ibexa-edit-header" #203
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making the toolbar to be on top of the header reintroduce this customer request:
https://issues.ibexa.co/browse/IBX-5743
@adamwojs : |
It looks like CKE has a different behavior now and disappears with offset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR tested on 4.6.x-dev, patch applied and successfully tested on v4.6.16.
I checked regression and z-index for custom tags
Problem likely introduced in fix for IBX-6354:
Description:
Toolbar appears below title/locaton header:
![image-2025-01-17-10-57-06-010](https://private-user-images.githubusercontent.com/289778/404269204-fd6323ec-66dd-4365-88ec-ea443b6f67b7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMjU4MzEsIm5iZiI6MTczOTMyNTUzMSwicGF0aCI6Ii8yODk3NzgvNDA0MjY5MjA0LWZkNjMyM2VjLTY2ZGQtNDM2NS04OGVjLWVhNDQzYjZmNjdiNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwMTU4NTFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hZjYwZGFkMjc4ZTE3MGJmNWUwNGM2OWVlNWZmOTdiMmI5YjE4M2MxMWNjMTI1MGQ3YjRhNThlYjJkNTVjNzNhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.weu9-HJIjUzR4d_HQYpZbeCBmAblgRrQhc_D-fWIajU)
After fix:
![image](https://private-user-images.githubusercontent.com/289778/404269757-f6db4474-33a4-4b67-978d-908f273f619e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMjU4MzEsIm5iZiI6MTczOTMyNTUzMSwicGF0aCI6Ii8yODk3NzgvNDA0MjY5NzU3LWY2ZGI0NDc0LTMzYTQtNGI2Ny05NzhkLTkwOGYyNzNmNjE5ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwMTU4NTFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01NzZkNzA3NTI4MGIxY2I1OTFiOTkwYzdkZDMxZTJmMTcyNmNlN2FjY2Q3MGQ1OTc5ZmQ0ZGVjOTEwYTAyMzk4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.LpzgS_uEUKra-TyYNmeSTYfStT2JYbuyce08uVXLeVQ)
Fix does not seem to break IBX-6354:
![image](https://private-user-images.githubusercontent.com/289778/404269693-54f24f6d-feba-4307-aaea-c48622ce7136.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMjU4MzEsIm5iZiI6MTczOTMyNTUzMSwicGF0aCI6Ii8yODk3NzgvNDA0MjY5NjkzLTU0ZjI0ZjZkLWZlYmEtNDMwNy1hYWVhLWM0ODYyMmNlNzEzNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwMTU4NTFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02ZTU3MWI1MTE5OTk1MDE5OGI3YmQ5YmM5NGRjMWQ4MjY0MTBhNWFkMjIxMmExZTk3Yjc3ZGZhODA3YjE3ZDVhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.JDldUF2JNsRTCMPs05P0xOAJM4tEW7KjMVuXi_swS2A)
For QA: