Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test for translation extraction #151

Merged
merged 11 commits into from
Mar 20, 2024
Merged

Added test for translation extraction #151

merged 11 commits into from
Mar 20, 2024

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Mar 11, 2024 •
edited
Loading

Question Answer
JIRA issue N/A
Improvement yes
New feature no
Target version 4.6
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mikadamczyk mikadamczyk self-assigned this Mar 11, 2024
@mikadamczyk mikadamczyk marked this pull request as ready for review March 11, 2024 13:56
@mikadamczyk mikadamczyk requested review from a team, Steveb-p, alongosz and konradoboza March 11, 2024 13:56
@mikadamczyk mikadamczyk changed the base branch from main to 4.6 March 15, 2024 11:38
alongosz
alongosz reviewed Mar 20, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
tests/integration/Resources/config.yaml Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz requested a review from a team March 20, 2024 10:33
@mikadamczyk mikadamczyk merged commit f3cb1bc into 4.6 Mar 20, 2024
21 checks passed
@mikadamczyk mikadamczyk deleted the translation-test branch March 20, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@konradoboza konradoboza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikadamczyk @alongosz @konradoboza