IBX-8470: Fixed outstanding issues after Symfony 6 upgrade

[tomaszszopinski]

🎫 Issue	IBX-8470

Description:

Issue 1: RetryChoiceListFactory

RetryChoiceListFactory decorates form.choice_list_factory Symfony Forms service, which in fact is an instance of \Symfony\Component\Form\ChoiceList\Factory\CachingFactoryDecorator decorating \Symfony\Component\Form\ChoiceList\Factory\PropertyAccessDecorator.

The issue was that the method signatures of those classes are not aligned with the implementing interface, with broader scope of mixed type instead of ?callable. Not sure if this is the proper direction, however choice_value configured via \Ibexa\AdminUi\Form\Type\Language\AbstractLanguageChoiceType::configureOptions is of scalar type, therefore causing a fatal error when trying to pass it as ?callable argument.

Instead, I've aligned RetryChoiceListFactory method signatures with PropertyAccessDecorator.

This happens only when Behat bundle is enabled, otherwise it performs a pass through CachingFactoryDecorator and PropertyAccessDecorator using string 'languageCode' as 2nd argument of createListFrom* methods.
Should we change choice_value to be a callable instead? Seems both types are okay: https://symfony.com/doc/6.4/reference/forms/types/choice.html#choice-value

Issue 2: UnauthenticatedRedirectController

UnauthenticatedRedirectController had injected @service_container directly along with performAccessCheck call. The method in the background tried to access security.authorization_checker service, which in Symfony 6 is private.

Per symfony/symfony#44391 conclusions and recommendations, I've changed the service to be auto-configured (when there's calls entry, it's not, despite _defaults) and I've refactored the controller to rather perform access check on specific action than when building service. It worked by accident due to the fact that the controller was being built on demand, instead of when building the whole container.

Kudos to @Steveb-p for the help with this one.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tomaszszopinski]

https://github.com/ibexa/oss/actions/runs/13154896672 - failure seem unrelated behat bundle regarding symfony6 upgrade.

[tomaszszopinski]

🟢 light to merge from me.